eldenmoon commented on code in PR #18654:
URL: https://github.com/apache/doris/pull/18654#discussion_r1191862959
##########
be/src/exec/rowid_fetcher.cpp:
##########
@@ -48,11 +52,15 @@
#include "vec/common/assert_cast.h"
#include "vec/common/string_ref.h"
#include "vec/core/block.h" // Block
+#include "vec/data_types/data_type_factory.hpp"
+#include "vec/jsonb/serialize.h"
namespace doris {
-Status RowIDFetcher::init(DorisNodesInfo* nodes_info) {
- for (auto [node_id, node_info] : nodes_info->nodes_info()) {
+Status RowIDFetcher::init() {
+ DorisNodesInfo nodes_info;
+ nodes_info.setNodes(_fetch_option.t_fetch_opt.nodes_info);
+ for (auto [node_id, node_info] : nodes_info.nodes_info()) {
Review Comment:
it' will get a connection from rpc connection pool instead of doing a
connect operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
