morningman commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r430974951



##########
File path: be/src/runtime/stream_load/stream_load_context.cpp
##########
@@ -70,6 +70,17 @@ std::string StreamLoadContext::to_json() const {
     writer.Int64(receive_bytes);
     writer.Key("LoadTimeMs");
     writer.Int64(load_cost_nanos / 1000000);
+    writer.Key("BeginTxnTimeMs");
+    writer.Int64(begin_txn_cost_nanos / 1000000);
+    writer.Key("StreamLoadPutTimeMs");
+    writer.Int64(stream_load_put_cost_nanos / 1000000);
+    writer.Key("ReadDataTimeMs");
+    writer.Int64(read_data_cost_nanos / 1000000);
+    writer.Key("WriteDataTimeMs");
+    writer.Int(write_data_cost_nanos / 1000000);
+    writer.Key("CommitAndPublishTimeMs");
+    writer.Int64(commit_and_publish_txn_cost_nanos / 1000000);

Review comment:
       modify the document of stream load to explain this new fields

##########
File path: docs/en/administrator-guide/config/be_config.md
##########
@@ -77,6 +77,12 @@ Sometimes the query fails and an error message of `The 
server is overcrowded` wi
 
 Since this is a brpc configuration, users can also modify this parameter 
directly during operation. Modify by visiting `http://be_host:brpc_port/flags`.
 
+### brpc_num_threads
+
+This configuration is mainly used to modify the num of bthreads for brpc. The 
default value is set to -1, which means the num of bthreads is #cpu-cores.
+
+User can set this configuration to a larger value to get better QPS 
performance.

Review comment:
       Better give an suggestion value or an example. eg: "In our env, we have 
xx BE with xx core, set this to xx, it can reach xx QPS"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to