morningman commented on code in PR #19492:
URL: https://github.com/apache/doris/pull/19492#discussion_r1192041751
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -507,12 +511,15 @@ public List<List<Comparable>> getDbInfo() {
try {
DatabaseTransactionMgr dbMgr = getDatabaseTransactionMgr(dbId);
runningNum = dbMgr.getRunningTxnNums() +
dbMgr.getRunningRoutineLoadTxnNums();
+ totalRunningNum += runningNum;
} catch (AnalysisException e) {
LOG.warn("get database running transaction num failed", e);
}
- info.add(runningNum);
+ info.add(String.valueOf(runningNum));
infos.add(info);
}
+ List<String> info = Arrays.asList("Total",
String.valueOf(dbIds.size()), String.valueOf(totalRunningNum));
Review Comment:
For the last line, better use same schema for each column:
I suggest：
```
0, "Total", runningnum
```
So that the first column is always integer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
