github-actions[bot] commented on code in PR #17881:
URL: https://github.com/apache/doris/pull/17881#discussion_r1192380780
##########
be/src/olap/task/engine_publish_version_task.cpp:
##########
@@ -17,20 +17,45 @@
#include "olap/task/engine_publish_version_task.h"
-#include <util/defer_op.h>
-
#include <map>
+#include "gen_cpp/AgentService_types.h"
#include "olap/data_dir.h"
+#include "olap/olap_define.h"
#include "olap/rowset/rowset_meta_manager.h"
+#include "olap/storage_engine.h"
#include "olap/tablet_manager.h"
+#include "util/defer_op.h"
namespace doris {
using namespace ErrorCode;
using std::map;
+class TabletPublishTxnTask {
+public:
+ TabletPublishTxnTask(EnginePublishVersionTask* engine_task,
TabletSharedPtr tablet,
+ RowsetSharedPtr rowset, int64_t partition_id, int64_t
transaction_id,
+ Version version, const TabletInfo& tablet_info,
+ std::atomic<int64_t>* total_task_num);
+ ~TabletPublishTxnTask() {}
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
~TabletPublishTxnTask() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
