wangbo commented on code in PR #19526:
URL: https://github.com/apache/doris/pull/19526#discussion_r1192953642
##########
be/src/runtime/memory/mem_tracker_limiter.cpp:
##########
@@ -459,10 +468,18 @@ int64_t
MemTrackerLimiter::free_top_overcommit_query(int64_t min_free_mem,
max_pq.pop();
}
if (!usage_strings.empty()) {
- LOG(INFO) << "Process GC Free Top Memory Overcommit " <<
TypeString[type] << ": "
+ LOG(INFO) << "Process GC Free Top Memory Overcommit " <<
type_string(type) << ": "
<< join(usage_strings, ",");
}
return freed_mem;
}
+void MemTrackerLimiter::add_to_task_group(taskgroup::TaskGroupPtr task_group) {
+ if (_task_group) {
Review Comment:
How about add DCHECK(_task_group == nullptr) here?
mem_tracker's task_group should be set only once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
