morningman commented on code in PR #19696:
URL: https://github.com/apache/doris/pull/19696#discussion_r1194846896
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OdbcTable.java:
##########
@@ -72,70 +72,36 @@ public class OdbcTable extends Table {
TABLE_TYPE_MAP = Collections.unmodifiableMap(tempMap);
}
- // For different databases, special characters need to be escaped
- private static String mysqlProperName(String name) {
- // In JdbcExternalTable, the name contains databaseName, like: db.table
- // So, we should split db and table, then switch to `db`.`table`.
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "`" + s +
"`").collect(Collectors.joining("."));
- }
-
- private static String mssqlProperName(String name) {
- // In JdbcExternalTable, the name contains databaseName, like: db.table
- // So, we should split db and table, then switch to [db].[table].
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "[" + s +
"]").collect(Collectors.joining("."));
- }
-
- private static String psqlProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s +
"\"").collect(Collectors.joining("."));
- }
-
- private static String oracleProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s.toUpperCase() +
"\"").collect(Collectors.joining("."));
- }
-
- private static String clickhouseProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s +
"\"").collect(Collectors.joining("."));
- }
-
- private static String saphanaProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s +
"\"").collect(Collectors.joining("."));
- }
-
- private static String trinoProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s +
"\"").collect(Collectors.joining("."));
- }
-
- private static String oceanbaseOracleProperName(String name) {
- List<String> list = Arrays.asList(name.split("\\."));
- return list.stream().map(s -> "\"" + s +
"\"").collect(Collectors.joining("."));
+ public static String formatName(String name, String wrapStart, String
wrapEnd, boolean toUpperCase, boolean toLowerCase) {
Review Comment:
Add comment to this method, better give some example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
