yiguolei commented on code in PR #19758:
URL: https://github.com/apache/doris/pull/19758#discussion_r1196559040
##########
be/src/vec/exprs/vexpr_context.cpp:
##########
@@ -105,6 +105,23 @@ doris::Status VExprContext::clone(RuntimeState* state,
VExprContext** new_ctx) {
return _root->open(state, *new_ctx, FunctionContext::THREAD_LOCAL);
}
+doris::Status VExprContext::clone(RuntimeState* state,
std::shared_ptr<VExprContext>& new_ctx) {
Review Comment:
maybe we could define ExprSPtr and changing both expr and exprcontext as
shared ptr, then we do not need add new method, just modify the original
method.
because I find there are many duplicate code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
