acelyc111 commented on pull request #3691: URL: https://github.com/apache/incubator-doris/pull/3691#issuecomment-636962937
> This CL LGTM. > > But I have reservations about changing some functions that originally returned `Status` to `Void`. > Although these functions currently have only one return value. But in terms of the properties of the function itself, some functions may return errors. Such as various `init` functions. > > So I suggest that if there are other similar places in the future, you can consider modifying them as appropriate according to the meaning of the function. OK. Agree with you that we should consider some functions may return various values, but I think if it currently always return a certain value, i.e. success status, we would better to use `void` to replace it. non-void return value may increase code and logic complexity, and make developers confused. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
