yiguolei commented on code in PR #19594:
URL: https://github.com/apache/doris/pull/19594#discussion_r1197660627
##########
be/src/vec/data_types/convert_field_to_type.cpp:
##########
@@ -107,18 +110,17 @@ Status convert_numric_type(const Field& from, const
IDataType& type, Field* to)
} else if (from.get_type() == Field::Types::Int128) {
*to = convert_numeric_type_impl<Int128, To>(from);
} else {
- return Status::InvalidArgument(
- fmt::format("Type mismatch in IN or VALUES section. Expected:
{}. Got: {}",
- type.get_name(), from.get_type()));
+ throw doris::Exception(ErrorCode::INVALID_ARGUMENT,
Review Comment:
are you sure segment writer or rowset writer is exception safe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
