morningman commented on code in PR #19759:
URL: https://github.com/apache/doris/pull/19759#discussion_r1197848331
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -367,6 +368,14 @@ public class SessionVariable implements Serializable,
Writable {
@VariableMgr.VarAttr(name = QUERY_TIMEOUT)
public int queryTimeoutS = 300;
+ // The global max_execution_time value provides the default for the
session value for new connections.
+ // The session value applies to SELECT executions executed within the
session that include
+ // no MAX_EXECUTION_TIME(N) optimizer hint or for which N is 0.
+ // https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html
+ // So that it is == query timeout in doris
+ @VariableMgr.VarAttr(name = MAX_EXECUTION_TIME, fuzzy = true, setter =
"setMaxExecutionTimeMS")
+ public int maxExecutionTimeMS = -1;
Review Comment:
Should the default value be same as `queryTimeout`?
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -367,6 +368,14 @@ public class SessionVariable implements Serializable,
Writable {
@VariableMgr.VarAttr(name = QUERY_TIMEOUT)
public int queryTimeoutS = 300;
+ // The global max_execution_time value provides the default for the
session value for new connections.
+ // The session value applies to SELECT executions executed within the
session that include
+ // no MAX_EXECUTION_TIME(N) optimizer hint or for which N is 0.
+ // https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html
+ // So that it is == query timeout in doris
+ @VariableMgr.VarAttr(name = MAX_EXECUTION_TIME, fuzzy = true, setter =
"setMaxExecutionTimeMS")
Review Comment:
use `description` field of `VariableMgr.VarAttr` to add comment of this
session variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
