morrySnow commented on code in PR #19863:
URL: https://github.com/apache/doris/pull/19863#discussion_r1198879408
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FoldConstantRuleOnFE.java:
##########
@@ -290,8 +290,9 @@ public Expression visitCast(Cast cast,
ExpressionRewriteContext context) {
@Override
public Expression visitBoundFunction(BoundFunction boundFunction,
ExpressionRewriteContext context) {
boundFunction = rewriteChildren(boundFunction, context);
- //functions, like current_date, do not have arg
- if (boundFunction.getArguments().isEmpty()) {
+ // functions related to current/local/now will be calculated by be.
Review Comment:
i think we should do constant folding on these functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
