imay commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r434973104
##########
File path: be/src/olap/row.h
##########
@@ -186,7 +186,12 @@ void agg_finalize_row(const std::vector<uint32_t>& ids,
RowType* row, MemPool* m
template<typename RowType>
uint32_t hash_row(const RowType& row, uint32_t seed) {
+ FieldType type;
for (uint32_t cid : row.schema()->column_ids()) {
+ type = row.schema()->column(cid)->type();
Review comment:
Should add comment for this `if` logical to let others know why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
