morningman commented on code in PR #19833:
URL: https://github.com/apache/doris/pull/19833#discussion_r1200620468
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -6402,7 +6402,23 @@ non_pred_expr ::=
| KW_NULL KW_IS KW_NOT KW_NULL
{: RESULT = new BoolLiteral(false); :}
| KW_CONVERT LPAREN expr:e COMMA type_def:targetType RPAREN
- {: RESULT = new CastExpr(targetType, e); :}
+ {:
+ CastExpr castExpr = new CastExpr(targetType, e);
Review Comment:
I think this should be implemented as a SQL RewriteRule, better not doing
any rewrite in parser.
And we also need to implement it in new query optimizer: Nereids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
