platoneko commented on code in PR #19063:
URL: https://github.com/apache/doris/pull/19063#discussion_r1201433466
##########
be/src/olap/storage_engine.h:
##########
@@ -286,6 +289,9 @@ class StorageEngine {
Status _handle_seg_compaction(BetaRowsetWriter* writer,
SegCompactionCandidatesSharedPtr segments);
+ Status _handle_index_change(IndexBuilderSharedPtr index_builder);
+ bool _tablet_busy(TabletSharedPtr tablet);
Review Comment:
```suggestion
bool _tablet_busy(Tablet* tablet);
```
Copying `shared_ptr` has cacheline synchronization overhead, but no need to
copy `shared_ptr` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
