kaijchen commented on code in PR #19099:
URL: https://github.com/apache/doris/pull/19099#discussion_r1201597555
##########
be/src/olap/memtable.cpp:
##########
@@ -425,6 +443,7 @@ Status MemTable::flush() {
// and use the ids to load segment data file for calc delete bitmap.
int64_t atomic_num_segments_before_flush =
_rowset_writer->get_atomic_num_segment();
RETURN_IF_ERROR(_do_flush(duration_ns));
+ _delta_writer_callback(_merged_rows);
Review Comment:
Why do we need this callback?
AFAIK, `_merged_rows` is already increased in
`DeltaWriter::_flush_memtable_async()`.
I suppose `_mem_table->merged_rows()` has not been updated here?
```cpp
Status DeltaWriter::_flush_memtable_async() {
_merged_rows += _mem_table->merged_rows();
return _flush_token->submit(std::move(_mem_table));
}
```
The callstack (one of the code paths):
```cpp
DeltaWriter::_flush_memtable_async();
=> FlushToken::submit();
=> FlushToken::_flush_memtable();
=> new MemtableFlushTask();
=> MemtableFlushTask::run();
=> MemTable::flush(); // in the latest master, equivalent to
MemTable::need_flush()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
