kangkaisen commented on a change in pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739#discussion_r436373596



##########
File path: be/src/olap/schema_change.cpp
##########
@@ -266,6 +260,92 @@ bool RowBlockChanger::change_row_block(
         int32_t ref_column = _schema_mapping[i].ref_column;
 
         if (_schema_mapping[i].ref_column >= 0) {
+            if (!_schema_mapping[i].materialized_function.empty()) {

Review comment:
       Would better abstract the materialized_view logic to a method. Add add 
more comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to