xinyiZzz commented on code in PR #20036:
URL: https://github.com/apache/doris/pull/20036#discussion_r1206146615


##########
be/src/olap/memtable.cpp:
##########
@@ -442,7 +442,7 @@ Status MemTable::flush() {
     // and new segment ids is between [atomic_num_segments_before_flush, 
atomic_num_segments_after_flush),
     // and use the ids to load segment data file for calc delete bitmap.
     int64_t atomic_num_segments_before_flush = 
_rowset_writer->get_atomic_num_segment();
-    RETURN_IF_ERROR(_do_flush(duration_ns));
+    SKIP_MEMORY_CHECK(RETURN_IF_ERROR(_do_flush(duration_ns)));

Review Comment:
   exception是在 `PageIO::compress_page_body` 捕获的,不排除 memtable flush 还有其他共用方法会抛出异常
   所以仅flush跳过



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to