bobhan1 commented on issue #18501: URL: https://github.com/apache/doris/issues/18501#issuecomment-1563767938
I think we should put the process of filling values for auto increment cols in XXXScaner instead of in `VOlapTable::sink()`, bacause `VOlapTable` lacks some neccessary information here. For example, if the user add parameter `-H columns: c1, c2=some_func(c1)` in a stream load task, where `c1` is an auto increment column. We can only calculate the values of `c2` in `VFileScanner::_fill_missing_columns()` becasue `VExprContex` for column transformation is only stored in `VFileScanner` and `VOlapTable` doesn't have the information about this. So for load task, the process of generating and filling auto increment values should be in `XXXScanner::_get_block_impl()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
