lvshaokang commented on code in PR #20068:
URL: https://github.com/apache/doris/pull/20068#discussion_r1206273519
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadJob.java:
##########
@@ -415,7 +415,11 @@ private void initDefaultJobProperties() {
timeout = Config.broker_load_default_timeout_second;
break;
case INSERT:
- timeout = Config.insert_load_default_timeout_second;
+ if (ConnectContext.get() != null) {
Review Comment:
Generally LGTM
But it would be better if the code style can be optimized. Similar to this
code, suggest remove redundant if..else
```suggestion
timeout = Optional.ofNullable(ConnectContext.get())
.map(ConnectContext::getExecTimeout)
.orElse(Config.insert_load_default_timeout_second)
```
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -452,7 +452,7 @@ public class Config extends ConfigBase {
@ConfField(mutable = true, masterOnly = true, description = {"Insert load
的默认超时时间，单位是秒。",
"Default timeout for insert load job, in seconds."})
- public static int insert_load_default_timeout_second = 3600; // 1 hour
+ public static int insert_load_default_timeout_second = 14400; // 4 hour
Review Comment:
Plz also change the value of the fe-config doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
