This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch dev_dtor in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git
commit 31dde3fcf4d3c4ef963717570d83f82d4b2fdf7a Author: BiteTheDDDDt <[email protected]> AuthorDate: Fri May 26 16:06:27 2023 +0800 fix non-virtual dtor for base class --- src/core/CLucene/util/CLStreams.h | 1 + src/core/CLucene/util/bkd/bkd_reader.h | 1 + src/core/CLucene/util/bkd/heap_point_writer.h | 2 +- src/core/CLucene/util/bkd/index_tree.h | 2 +- src/core/CLucene/util/bkd/point_reader.h | 1 + src/core/CLucene/util/bkd/point_writer.h | 2 +- 6 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/core/CLucene/util/CLStreams.h b/src/core/CLucene/util/CLStreams.h index 35b5dd04..e9d60754 100644 --- a/src/core/CLucene/util/CLStreams.h +++ b/src/core/CLucene/util/CLStreams.h @@ -11,6 +11,7 @@ CL_NS_DEF(util) class IReader { public: + virtual ~IReader() = default; virtual int32_t read(const void **start, int32_t min, int32_t max) = 0; virtual int64_t skip(int64_t ntoskip) = 0; virtual int64_t position() = 0; diff --git a/src/core/CLucene/util/bkd/bkd_reader.h b/src/core/CLucene/util/bkd/bkd_reader.h index db72ce58..adb7f3da 100644 --- a/src/core/CLucene/util/bkd/bkd_reader.h +++ b/src/core/CLucene/util/bkd/bkd_reader.h @@ -52,6 +52,7 @@ public: public: class intersect_visitor { public: + virtual ~intersect_visitor() = default; virtual void visit(int docid) = 0; /** Called for all documents in a leaf cell that crosses the query. The diff --git a/src/core/CLucene/util/bkd/heap_point_writer.h b/src/core/CLucene/util/bkd/heap_point_writer.h index 7b9d58e8..215119fc 100644 --- a/src/core/CLucene/util/bkd/heap_point_writer.h +++ b/src/core/CLucene/util/bkd/heap_point_writer.h @@ -52,7 +52,7 @@ namespace bkd void destroy() override; std::string to_string(); - ~heap_point_writer(); + ~heap_point_writer() override; }; } // namespace bkd CL_NS_END diff --git a/src/core/CLucene/util/bkd/index_tree.h b/src/core/CLucene/util/bkd/index_tree.h index d6342806..a13a4e20 100644 --- a/src/core/CLucene/util/bkd/index_tree.h +++ b/src/core/CLucene/util/bkd/index_tree.h @@ -12,6 +12,7 @@ protected: explicit index_tree(std::shared_ptr<bkd_reader>& reader); public: + virtual ~index_tree() = default; virtual void push_left(); virtual void push_right(); virtual void pop(); @@ -24,7 +25,6 @@ public: virtual std::shared_ptr<index_tree> clone() = 0; virtual std::shared_ptr<BytesRef> get_split_dim_value() = 0; virtual int64_t get_leaf_blockFP() = 0; - private: int32_t GetNumLeavesSlow(int32_t node); diff --git a/src/core/CLucene/util/bkd/point_reader.h b/src/core/CLucene/util/bkd/point_reader.h index 190d94e0..a34c6676 100644 --- a/src/core/CLucene/util/bkd/point_reader.h +++ b/src/core/CLucene/util/bkd/point_reader.h @@ -10,6 +10,7 @@ CL_NS_DEF2(util, bkd) class point_reader { public: + virtual ~point_reader() = default; virtual bool next() = 0; virtual const std::vector<uint8_t> &packed_value() = 0; virtual uint8_t* packed_value_raw() = 0; diff --git a/src/core/CLucene/util/bkd/point_writer.h b/src/core/CLucene/util/bkd/point_writer.h index 55241ca1..fb0128a4 100644 --- a/src/core/CLucene/util/bkd/point_writer.h +++ b/src/core/CLucene/util/bkd/point_writer.h @@ -10,7 +10,7 @@ class point_reader; class point_writer { public: point_writer(/* args */)= default;; - ~point_writer() { close(); }; + virtual ~point_writer() { close(); }; virtual void append(const std::vector<uint8_t> &packed_value, int64_t ord, int32_t doc_id) = 0; virtual void append(const uint8_t* packedValue, uint32_t value_length, int64_t ord, int32_t docid) = 0; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
