xiaokang commented on code in PR #19237:
URL: https://github.com/apache/doris/pull/19237#discussion_r1206415821
##########
be/src/olap/snapshot_manager.cpp:
##########
@@ -412,9 +412,28 @@ Status SnapshotManager::_create_snapshot_files(const
TabletSharedPtr& ref_tablet
if (ref_tablet->tablet_state() == TABLET_SHUTDOWN) {
return Status::Aborted("tablet has shutdown");
}
+ bool is_compaction_clone =
Review Comment:
is_single_rowset_clone
##########
gensrc/thrift/AgentService.thrift:
##########
@@ -39,9 +39,10 @@ struct TTabletSchema {
11: optional Types.TSortType sort_type
12: optional i32 sort_col_num
13: optional bool disable_auto_compaction
- 14: optional i32 version_col_idx = -1
- 15: optional bool is_dynamic_schema = false
- 16: optional bool store_row_column = false
+ 14: optional bool enable_single_replica_compaction
Review Comment:
move it to last one for compatibility
##########
gensrc/proto/olap_file.proto:
##########
@@ -227,12 +227,13 @@ message TabletSchemaPB {
optional segment_v2.CompressionTypePB compression_type = 13 [default=LZ4F];
optional int32 schema_version = 14;
optional bool disable_auto_compaction = 15 [default=false];
- repeated TabletIndexPB index = 16;
- optional int32 version_col_idx = 17 [default = -1];
- optional bool store_row_column = 18 [default=false]; // store tuplerow
oriented column
- optional bool is_dynamic_schema = 19 [default=false];
- optional bool is_partial_update = 20 [default=false];
- repeated string partial_update_input_columns = 21;
+ optional bool enable_single_replica_compaction = 16 [default=false];
Review Comment:
move it to last one for compatibility
##########
be/src/common/config.cpp:
##########
@@ -370,6 +371,9 @@ DEFINE_mInt64(total_permits_for_compaction_score, "10000");
// sleep interval in ms after generated compaction tasks
DEFINE_mInt32(generate_compaction_tasks_interval_ms, "10");
+// sleep interval in second after update replica infos
+DEFINE_mInt32(update_replica_infos_interval_seconds, "10");
Review Comment:
60s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
