yiguolei commented on code in PR #20028:
URL: https://github.com/apache/doris/pull/20028#discussion_r1208560730
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -404,11 +387,11 @@ class InvertedIndexColumnWriterImpl : public
InvertedIndexColumnWriter {
roaring::Roaring _null_bitmap;
uint64_t _reverted_index_size;
- lucene::document::Document* _doc {};
+ std::unique_ptr<lucene::document::Document> _doc {};
lucene::document::Field* _field {};
Review Comment:
why this is not a unique ptr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]