This is an automated email from the ASF dual-hosted git repository. zhangchen pushed a commit to branch branch-1.2-lts in repository https://gitbox.apache.org/repos/asf/doris.git
commit 5f7e7d7cb4ae823c001b830f7d6365643fa8647e Author: Xin Liao <[email protected]> AuthorDate: Thu May 18 08:41:49 2023 +0800 [enhancement](merge-on-write) Avoiding unnecessary primary key index traversal (#19746) --- be/src/olap/tablet.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp index 9b1c68f4e1..06c0572d80 100644 --- a/be/src/olap/tablet.cpp +++ b/be/src/olap/tablet.cpp @@ -2241,8 +2241,10 @@ Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const TabletT delete_bitmap->remove({to_del, 0, 0}, {to_del, UINT32_MAX, INT64_MAX}); } - RETURN_IF_ERROR(calc_delete_bitmap(rowset->rowset_id(), segments, &rowset_ids_to_add, - delete_bitmap, cur_version - 1, false)); + if (!rowset_ids_to_add.empty()) { + RETURN_IF_ERROR(calc_delete_bitmap(rowset->rowset_id(), segments, &rowset_ids_to_add, + delete_bitmap, cur_version - 1, false)); + } // update version without write lock, compaction and publish_txn // will update delete bitmap, handle compaction with _rowset_update_lock --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
