DarvenDuan commented on code in PR #20078:
URL: https://github.com/apache/doris/pull/20078#discussion_r1221303590
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -1370,53 +1374,40 @@ Status
NewJsonReader::_simdjson_handle_nested_complex_json(
return Status::OK();
}
-size_t NewJsonReader::_column_index(const StringRef& name, size_t key_index) {
Review Comment:
> this function accelerate parsing speed, do not delete it
I think this method is used to get the index of a column in a block, but if
we iterate `slot_descs` through `for (size_t i = 0; i < slot_descs.size();
++i)` instead of iterating `*value` through `for (auto field : *value)`, we can
get the index `i` directly, whether this method can be deleted or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
