kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r442869778
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -248,6 +259,149 @@ void PushHandler::_get_tablet_infos(const
vector<TabletVars>& tablet_vars,
}
}
+OLAPStatus PushHandler::_convert_v2(TabletSharedPtr cur_tablet,
+ TabletSharedPtr new_tablet,
+ RowsetSharedPtr* cur_rowset,
+ RowsetSharedPtr* new_rowset) {
+ OLAPStatus res = OLAP_SUCCESS;
+ PushBrokerReader* reader = nullptr;
Review comment:
Could use std::unique_ptr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
