liaoxin01 commented on code in PR #20706:
URL: https://github.com/apache/doris/pull/20706#discussion_r1229222044
##########
be/src/service/point_query_executor.cpp:
##########
@@ -264,7 +265,7 @@ Status PointQueryExecutor::_lookup_row_key() {
// Get rowlocation and rowset, ctx._rowset_ptr will acquire wrap this
ptr
auto rowset_ptr = std::make_unique<RowsetSharedPtr>();
st = (_tablet->lookup_row_key(_row_read_ctxs[i]._primary_key, true,
nullptr, &location,
- INT32_MAX /*rethink?*/,
rowset_ptr.get()));
+ INT32_MAX /*rethink?*/, segment_caches,
rowset_ptr.get()));
Review Comment:
`_row_read_ctxs` may have multiple keys to lookup，so I think we also need a
segment cache here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
