AshinGau commented on code in PR #19990:
URL: https://github.com/apache/doris/pull/19990#discussion_r1232092692
##########
be/src/vec/exec/jni_connector.h:
##########
@@ -165,9 +165,28 @@ class JniConnector {
_scanner_params(std::move(scanner_params)),
_column_names(std::move(column_names)) {}
+ /**
+ * Use configuration map to provide scan information. The java side should
determine how the parameters are parsed.
+ * @param connector_class Java scanner class
+ * @param scanner_params Provided configuration map
+ */
+ JniConnector(std::string connector_class, std::map<std::string,
std::string> scanner_params)
+ : _connector_class(std::move(connector_class)),
+ _scanner_params(std::move(scanner_params)) {
+ _is_table_schema = true;
Review Comment:
I should add identifiers on the Java side and decide how to clean up memory
on the Java side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
