xinyiZzz commented on code in PR #20771:
URL: https://github.com/apache/doris/pull/20771#discussion_r1233635822
##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -939,10 +930,10 @@ void VNodeChannel::_close_check() {
CHECK(_cur_mutable_block == nullptr) << name();
}
-void VNodeChannel::mark_close() {
- auto st = none_of({_cancelled, _eos_is_produced});
- if (!st.ok()) {
- return;
+Status VNodeChannel::mark_close() {
+ DCHECK(!_eos_is_produced);
Review Comment:
mark_close() 只在 VOlapTableSink::try_close 中用到了，已正确处理返回的Status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
