This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new eb6202e8be [minor](fe) remove several unnecessary codes (#21046)
eb6202e8be is described below
commit eb6202e8be6bbe50f069473c158c046e100586c5
Author: shenxingwuying <[email protected]>
AuthorDate: Thu Jun 22 15:29:25 2023 +0800
[minor](fe) remove several unnecessary codes (#21046)
1. The class 'ExternalDatabase' has implemented the 'GsonPostProcessable'
interface, so
there is redundant codes in some subclass of 'ExternalDatabase'.
2. A LOG object is not used in this file.
---
.../java/org/apache/doris/catalog/external/EsExternalDatabase.java | 3 +--
.../java/org/apache/doris/catalog/external/HMSExternalDatabase.java | 3 +--
.../org/apache/doris/catalog/external/IcebergExternalDatabase.java | 3 +--
.../java/org/apache/doris/catalog/external/JdbcExternalDatabase.java | 3 +--
.../org/apache/doris/catalog/external/MaxComputeExternalDatabase.java | 4 +---
.../org/apache/doris/catalog/external/PaimonExternalDatabase.java | 3 +--
.../java/org/apache/doris/catalog/external/TestExternalDatabase.java | 3 +--
.../main/java/org/apache/doris/datasource/JdbcExternalCatalog.java | 4 ----
8 files changed, 7 insertions(+), 19 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/EsExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/EsExternalDatabase.java
index 5d020789b0..f3a3118444 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/EsExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/EsExternalDatabase.java
@@ -20,12 +20,11 @@ package org.apache.doris.catalog.external;
import org.apache.doris.datasource.EsExternalCatalog;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
/**
* Elasticsearch metastore external database.
*/
-public class EsExternalDatabase extends ExternalDatabase<EsExternalTable>
implements GsonPostProcessable {
+public class EsExternalDatabase extends ExternalDatabase<EsExternalTable> {
/**
* Create Elasticsearch external database.
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalDatabase.java
index 01c62ee1ea..d53c934052 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalDatabase.java
@@ -21,7 +21,6 @@ import org.apache.doris.catalog.TableIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.HMSExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -33,7 +32,7 @@ import java.util.stream.Collectors;
/**
* Hive metastore external database.
*/
-public class HMSExternalDatabase extends ExternalDatabase<HMSExternalTable>
implements GsonPostProcessable {
+public class HMSExternalDatabase extends ExternalDatabase<HMSExternalTable> {
private static final Logger LOG =
LogManager.getLogger(HMSExternalDatabase.class);
/**
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/IcebergExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/IcebergExternalDatabase.java
index 96175487e6..3e8a7beef9 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/IcebergExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/IcebergExternalDatabase.java
@@ -21,7 +21,6 @@ import org.apache.doris.catalog.TableIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
import org.apache.doris.datasource.iceberg.IcebergExternalCatalog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -30,7 +29,7 @@ import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;
-public class IcebergExternalDatabase extends
ExternalDatabase<IcebergExternalTable> implements GsonPostProcessable {
+public class IcebergExternalDatabase extends
ExternalDatabase<IcebergExternalTable> {
private static final Logger LOG =
LogManager.getLogger(IcebergExternalDatabase.class);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/JdbcExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/JdbcExternalDatabase.java
index e60ca3dfe4..ce3b3726a9 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/JdbcExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/JdbcExternalDatabase.java
@@ -20,9 +20,8 @@ package org.apache.doris.catalog.external;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
import org.apache.doris.datasource.JdbcExternalCatalog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
-public class JdbcExternalDatabase extends ExternalDatabase<JdbcExternalTable>
implements GsonPostProcessable {
+public class JdbcExternalDatabase extends ExternalDatabase<JdbcExternalTable> {
/**
* Create Jdbc external database.
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/MaxComputeExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/MaxComputeExternalDatabase.java
index 56e892eab1..df94d775c1 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/MaxComputeExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/MaxComputeExternalDatabase.java
@@ -20,13 +20,11 @@ package org.apache.doris.catalog.external;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
import org.apache.doris.datasource.MaxComputeExternalCatalog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
/**
* MaxCompute external database.
*/
-public class MaxComputeExternalDatabase extends
ExternalDatabase<MaxComputeExternalTable>
- implements GsonPostProcessable {
+public class MaxComputeExternalDatabase extends
ExternalDatabase<MaxComputeExternalTable> {
/**
* Create MaxCompute external database.
*
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/PaimonExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/PaimonExternalDatabase.java
index ac6d6932c6..4f6014241a 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/PaimonExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/PaimonExternalDatabase.java
@@ -21,7 +21,6 @@ import org.apache.doris.catalog.TableIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
import org.apache.doris.datasource.paimon.PaimonExternalCatalog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -30,7 +29,7 @@ import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;
-public class PaimonExternalDatabase extends
ExternalDatabase<PaimonExternalTable> implements GsonPostProcessable {
+public class PaimonExternalDatabase extends
ExternalDatabase<PaimonExternalTable> {
private static final Logger LOG =
LogManager.getLogger(PaimonExternalDatabase.class);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/TestExternalDatabase.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/TestExternalDatabase.java
index fbac107f45..812965674c 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/catalog/external/TestExternalDatabase.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/catalog/external/TestExternalDatabase.java
@@ -20,9 +20,8 @@ package org.apache.doris.catalog.external;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.InitDatabaseLog;
import org.apache.doris.datasource.test.TestExternalCatalog;
-import org.apache.doris.persist.gson.GsonPostProcessable;
-public class TestExternalDatabase extends ExternalDatabase<TestExternalTable>
implements GsonPostProcessable {
+public class TestExternalDatabase extends ExternalDatabase<TestExternalTable> {
public TestExternalDatabase(ExternalCatalog extCatalog, long id, String
name) {
super(extCatalog, id, name, InitDatabaseLog.Type.TEST);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/JdbcExternalCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/JdbcExternalCatalog.java
index 9b0700b81c..583cceddd6 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/JdbcExternalCatalog.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/JdbcExternalCatalog.java
@@ -28,16 +28,12 @@ import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import lombok.Getter;
import org.apache.commons.lang3.StringUtils;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
import java.util.List;
import java.util.Map;
@Getter
public class JdbcExternalCatalog extends ExternalCatalog {
- private static final Logger LOG =
LogManager.getLogger(JdbcExternalCatalog.class);
-
private static final List<String> REQUIRED_PROPERTIES = Lists.newArrayList(
JdbcResource.JDBC_URL,
JdbcResource.DRIVER_URL,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
