airborne12 commented on code in PR #21310:
URL: https://github.com/apache/doris/pull/21310#discussion_r1248374762
##########
be/src/olap/null_predicate.h:
##########
@@ -92,7 +94,7 @@ class NullPredicate : public ColumnPredicate {
}
}
- bool can_do_bloom_filter() const override { return _is_null; }
+ bool can_do_bloom_filter(bool ngram) const override { return ngram ? false
: _is_null; }
Review Comment:
may be `bool can_do_bloom_filter(bool ngram) const override { return !ngram
&& _is_null; }` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
