jacktengg opened a new pull request, #21420:
URL: https://github.com/apache/doris/pull/21420

   and remove prefetch when insert data into columns, because it's effect is 
not stable in production env.
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   For the following test:
   ```
       {
           auto col = doris::vectorized::ColumnString::create();
           constexpr int build_rows = 5131;
           constexpr int output_rows = 435699854;
           std::string str("01234567");
           for (int i = 0; i < build_rows; ++i) {
               col->insert_data(str.data(), str.size());
           }
           int indices[output_rows];
           for (int i = 0; i < output_rows; ++i) {
               indices[i] = i % build_rows;
           }
           auto col2 = doris::vectorized::ColumnString::create();
           doris::MonotonicStopWatch watch;
           watch.start();
           col2->insert_indices_from(*col, indices, indices + output_rows);
           watch.stop();
           LOG(WARNING) << "string column insert_indices_from, rows: " << 
output_rows << ", time: " << doris::PrettyPrinter::print(watch.elapsed_time(), 
doris::TUnit::TIME_NS);
       }
   ```
   The inserting time improve from 6s665ms to 3s158ms
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[[email protected]](mailto:[email protected]) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to