morningman commented on code in PR #21440:
URL: https://github.com/apache/doris/pull/21440#discussion_r1251780697
##########
be/src/runtime/user_function_cache.cpp:
##########
@@ -271,10 +285,13 @@ Status UserFunctionCache::_download_lib(const
std::string& url,
Md5Digest digest;
HttpClient client;
+ int64_t file_size;
RETURN_IF_ERROR(client.init(real_url));
Status status;
- auto download_cb = [&status, &tmp_file, &fp, &digest](const void* data,
size_t length) {
+ auto download_cb = [&status, &tmp_file, &fp, &digest, &file_size](const
void* data,
+ size_t
length) {
digest.update(data, length);
+ file_size = file_size + length;
Review Comment:
what is the init value of `file_size`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
