yiguolei commented on code in PR #21483:
URL: https://github.com/apache/doris/pull/21483#discussion_r1251859637


##########
be/src/vec/common/allocator.h:
##########
@@ -138,7 +145,7 @@ class Allocator {
     }
 
     /// Free memory range.
-    void free(void* buf, size_t size = -1) {

Review Comment:
   It will core, if the memory is not allocated by using Allocator's alloc 
method because it will deal mmap, chunk allocator inside the allocator. For 
example, if the memory is alloc by using malloc, its size maybe 128MB, and then 
you call Allocator::free, allocator will try use munmap to free the memory.
   Could you please provide more detail info about the RPC's zero copy?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to