github-actions[bot] commented on PR #21516:
URL: https://github.com/apache/doris/pull/21516#issuecomment-1621106326
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5461113774";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/run-fs-benchmark.sh line 74:
if [[ ! -z "${HADOOP_CONF_DIR}" ]]; then
^-- SC2236 (style): Use -n instead of ! -z.
In bin/run-fs-benchmark.sh line 84:
export
LD_LIBRARY_PATH="${DORIS_HOME}/lib/hadoop_hdfs/native:$LD_LIBRARY_PATH"
^--------------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
export
LD_LIBRARY_PATH="${DORIS_HOME}/lib/hadoop_hdfs/native:${LD_LIBRARY_PATH}"
In bin/start_be.sh line 105:
if [[ ! -z "${HADOOP_CONF_DIR}" ]]; then
^-- SC2236 (style): Use -n instead of ! -z.
In bin/start_be.sh line 115:
export
LD_LIBRARY_PATH="${DORIS_HOME}/lib/hadoop_hdfs/native:$LD_LIBRARY_PATH"
^--------------^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
export
LD_LIBRARY_PATH="${DORIS_HOME}/lib/hadoop_hdfs/native:${LD_LIBRARY_PATH}"
In thirdparty/build-thirdparty.sh line 1586:
rm -rf ${TP_INSTALL_DIR}/lib/hadoop_hdfs/native/*.a
^---------------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
Did you mean:
rm -rf "${TP_INSTALL_DIR}"/lib/hadoop_hdfs/native/*.a
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2236 -- Use -n instead of ! -z.
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
