morningman commented on a change in pull request #4088:
URL: https://github.com/apache/incubator-doris/pull/4088#discussion_r455464635
##########
File path: fe/src/main/java/org/apache/doris/clone/TabletScheduler.java
##########
@@ -879,9 +880,14 @@ private void deleteReplicaInternal(TabletSchedCtx
tabletCtx, Replica replica, St
throw new SchedException(Status.SCHEDULE_FAILED, "set watermark
txn " + nextTxnId);
} else if (replica.getState() == ReplicaState.DECOMMISSION &&
replica.getWatermarkTxnId() != -1) {
long watermarkTxnId = replica.getWatermarkTxnId();
- if
(!Catalog.getCurrentGlobalTransactionMgr().isPreviousTransactionsFinished(watermarkTxnId,
- tabletCtx.getDbId(),
Lists.newArrayList(tabletCtx.getTblId()))) {
- throw new SchedException(Status.SCHEDULE_FAILED, "wait txn
before " + watermarkTxnId + " to be finished");
+ try {
+ if
(!Catalog.getCurrentGlobalTransactionMgr().isPreviousTransactionsFinished(watermarkTxnId,
+ tabletCtx.getDbId(),
Lists.newArrayList(tabletCtx.getTblId()))) {
+ throw new SchedException(Status.SCHEDULE_FAILED,
Review comment:
bear it! LOL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
