github-actions[bot] commented on PR #20716:
URL: https://github.com/apache/doris/pull/20716#issuecomment-1628443671
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5505596267";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In minidump/nereids_ut.sh line 172:
${JAVA} ${final_java_opt} -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}" ${OPT_VERSION} "$@" >
${temp_file}
^---------------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^------------^ SC2248 (style): Prefer double quoting even when
variables don't contain special characters.
^----------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
Did you mean:
${JAVA} "${final_java_opt}" -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}" "${OPT_VERSION}" "$@" >
"${temp_file}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when
v...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- minidump/nereids_ut.sh.orig
+++ minidump/nereids_ut.sh
@@ -169,7 +169,7 @@
if [[ -d "${dir}" ]]; then # Check if the path is a directory
query_id=${dir: -33}
temp_file=${LOG_DIR}/temp
- ${JAVA} ${final_java_opt} -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}" ${OPT_VERSION} "$@" >
${temp_file}
+ ${JAVA} ${final_java_opt} -Xmx2g
org.apache.doris.nereids.minidump.Minidump "${dir}" ${OPT_VERSION} "$@"
>${temp_file}
result=$(cat "${temp_file}")
echo "${query_id_head} ${query_id} ${sql_head} ${result}" | tee
>>"${LOG_DIR}/minidump.out"
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
