zhannngchen commented on code in PR #21177:
URL: https://github.com/apache/doris/pull/21177#discussion_r1261074096
##########
be/src/olap/compaction.cpp:
##########
@@ -716,6 +720,25 @@ Status Compaction::check_version_continuity(const
std::vector<RowsetSharedPtr>&
return Status::OK();
}
+Status Compaction::check_all_version(const std::vector<RowsetSharedPtr>&
rowsets) {
Review Comment:
Why add such a method in base class? It's only used in FullCompaction
##########
be/src/olap/tablet.cpp:
##########
@@ -3248,6 +3266,82 @@ Status Tablet::commit_phase_update_delete_bitmap(
return Status::OK();
}
+Status Tablet::full_compaction_update_delete_bitmap(const RowsetSharedPtr&
rowset,
Review Comment:
Is it possible to move these methods to FullCompaction class? Too much
xx_update_delete_bitmap in Tablet class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
