morningman commented on code in PR #21761:
URL: https://github.com/apache/doris/pull/21761#discussion_r1261367446
##########
be/src/vec/runtime/vorc_writer.h:
##########
@@ -98,7 +98,8 @@ class VOrcWriterWrapper final : public VFileWriterWrapper {
std::unique_ptr<orc::Type> _schema;
std::unique_ptr<orc::Writer> _writer;
- static constexpr size_t BUFFER_UNIT_SIZE = 4096;
+ static constexpr size_t BUFFER_UNIT_SIZE = 4096 * 32;
Review Comment:
Why multiple 32? add comment in code.
And for the magic number 50, also add some explaination in code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
