AshinGau commented on code in PR #21675:
URL: https://github.com/apache/doris/pull/21675#discussion_r1261902175
##########
be/src/vec/exec/format/parquet/parquet_pred_cmp.h:
##########
@@ -372,7 +379,8 @@ class ParquetPredicate {
static bool filter_by_stats(const ColumnValueRangeType& col_val_range,
const FieldSchema* col_schema, bool
is_set_min_max,
const std::string& encoded_min, const
std::string& encoded_max,
- bool is_all_null, const cctz::time_zone& ctz) {
+ bool is_all_null, const cctz::time_zone& ctz,
+ bool use_min_max_value = false) {
Review Comment:
How about take `tparquet::Statistics` as parameters? In this way, the fix
process can be encapsulated inside the function instead of being judged
externally, and there is no need to pass so many parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
