zhannngchen commented on code in PR #21760:
URL: https://github.com/apache/doris/pull/21760#discussion_r1261909690
##########
be/src/olap/compaction.cpp:
##########
@@ -613,17 +613,21 @@ Status Compaction::modify_rowsets(const
Merger::Statistics* stats) {
// Step2: calculate all rowsets' delete bitmaps which are
published during compaction.
for (auto& it : commit_tablet_txn_info_vec) {
- DeleteBitmap output_delete_bitmap(_tablet->tablet_id());
- _tablet->calc_compaction_output_rowset_delete_bitmap(
- _input_rowsets, _rowid_conversion, 0, UINT64_MAX,
&missed_rows,
- &location_map, *it.delete_bitmap.get(),
&output_delete_bitmap);
- it.delete_bitmap->merge(output_delete_bitmap);
- // Step3: write back updated delete bitmap and tablet info.
- it.rowset_ids.insert(_output_rowset->rowset_id());
-
StorageEngine::instance()->txn_manager()->set_txn_related_delete_bitmap(
- it.partition_id, it.transaction_id,
_tablet->tablet_id(),
- _tablet->schema_hash(), _tablet->tablet_uid(), true,
it.delete_bitmap,
- it.rowset_ids);
+ if (check_if_includes_input_rowsets(it.rowset_ids)) {
Review Comment:
Add some comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
