zhannngchen commented on code in PR #21773:
URL: https://github.com/apache/doris/pull/21773#discussion_r1262521623
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -587,6 +598,17 @@ Status SegmentWriter::append_block(const
vectorized::Block* block, size_t row_po
<< "found duplicate key or key is not sorted! current
key: " << key
<< ", last key" << last_key;
RETURN_IF_ERROR(_primary_key_index_builder->add_item(key));
+ if (is_unique_key_ignore_mode) {
+ RowLocation loc;
+ RowsetSharedPtr rowset;
+ auto status = _tablet->lookup_row_key(key, false,
specified_rowsets, &loc,
Review Comment:
Don't check if key exists here, you should change the behavior of all the
places of update delete bitmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
