platoneko commented on code in PR #21670:
URL: https://github.com/apache/doris/pull/21670#discussion_r1264992481
##########
be/src/olap/cumulative_compaction_time_series_policy.cpp:
##########
@@ -137,9 +137,7 @@ void
TimeSeriesCumulativeCompactionPolicy::calculate_cumulative_point(
// check the rowset is whether less than _compaction_goal_size
// The result of compaction may be slightly smaller than the
_compaction_goal_size.
- if (!is_delete && rs->version().first != 0 &&
- rs->total_disk_size() <
- (config::time_series_compaction_goal_size_mbytes * 1024 *
1024 * 0.8)) {
+ if (!is_delete && rs->version().first != 0 && rs->version().first ==
rs->version().second) {
Review Comment:
```suggestion
if (!is_delete && rs->version().first == rs->version().second) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
