yiguolei commented on code in PR #21890:
URL: https://github.com/apache/doris/pull/21890#discussion_r1266025786
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -65,9 +65,12 @@
namespace doris::vectorized {
-#define RETURN_IF_PUSH_DOWN(stmt) \
+#define RETURN_IF_PUSH_DOWN(stmt, state) \
Review Comment:
not use state, use status please.
##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -472,34 +475,44 @@ Status VScanNode::_normalize_predicate(const VExprSPtr&
conjunct_expr_root, VExp
}
if (_is_predicate_acting_on_slot(cur_expr, in_predicate_checker,
&slot, &range) ||
_is_predicate_acting_on_slot(cur_expr, eq_predicate_checker,
&slot, &range)) {
+ Status state = Status::OK();
Review Comment:
use status not state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
