kaijchen commented on code in PR #21746:
URL: https://github.com/apache/doris/pull/21746#discussion_r1266335203
##########
be/src/olap/delta_writer.cpp:
##########
@@ -398,6 +398,7 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes&
slave_tablet_nodes,
_mem_table.reset();
+ _num_rows_filtered += _rowset_writer->num_rows_filtered();
Review Comment:
I think we don't need to accumulate this value again in DeltaWriter, because
there is only one rowset writer in one delta writer.
```cpp
int64_t DeltaWriter::num_rows_filtered() {
return _rowset_writer == nullptr ? 0 :
_rowset_writer->num_rows_filtered();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
