morrySnow commented on code in PR #22019:
URL: https://github.com/apache/doris/pull/22019#discussion_r1268884177
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/UserAuthentication.java:
##########
@@ -55,14 +56,16 @@ private Plan checkPermission(LogicalRelation relation,
ConnectContext connectCon
}
if (relationsToCheck.contains(relation.getClass())) {
Review Comment:
do we need update relationsToCheck list?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/UserAuthentication.java:
##########
@@ -55,14 +56,16 @@ private Plan checkPermission(LogicalRelation relation,
ConnectContext connectCon
}
if (relationsToCheck.contains(relation.getClass())) {
- String dbName =
- !relation.getQualifier().isEmpty() ?
relation.getQualifier().get(0) : null;
- String tableName = relation.getTable().getName();
- if
(!connectContext.getEnv().getAccessManager().checkTblPriv(connectContext,
dbName,
+ TableIf table = relation.getTable();
Review Comment:
not all relation has table, so u need to check null here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
