morningman commented on a change in pull request #4136:
URL: https://github.com/apache/incubator-doris/pull/4136#discussion_r462211888
##########
File path: be/src/exec/json_scanner.h
##########
@@ -143,10 +140,12 @@ class JsonReader {
bool _strip_outer_array;
RuntimeProfile::Counter* _bytes_read_counter;
RuntimeProfile::Counter* _read_timer;
+
std::vector<std::vector<JsonPath>> _parsed_jsonpaths;
- rapidjson::Document _json_doc;
- //key: column name
- std::unordered_map<std::string, JsonDataInternal> _jmap;
+ std::vector<JsonPath> _parsed_json_root;
+
+ rapidjson::Document _orinal_json_doc; // orinal json document object from
parsed json string
Review comment:
```suggestion
rapidjson::Document _origin_json_doc; // orinal json document object
from parsed json string
```
##########
File path: be/src/http/http_common.h
##########
@@ -37,6 +37,7 @@ static const std::string HTTP_STRICT_MODE = "strict_mode";
static const std::string HTTP_TIMEZONE = "timezone";
static const std::string HTTP_EXEC_MEM_LIMIT = "exec_mem_limit";
static const std::string HTTP_EXEC_JSONPATHS = "jsonpaths";
+static const std::string HTTP_EXEC_JSONROOT = "json_root";
Review comment:
```suggestion
static const std::string HTTP_JSONROOT = "json_root";
```
EXEC is not some kind of prfix, it is with `EXEC_MEM_LIMIT`.
Also modify `HTTP_EXEC_JSONPATHS` to `HTTP_JSONPATHS`
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
##########
@@ -17,6 +17,14 @@
package org.apache.doris.load.routineload;
+import com.google.common.base.Joiner;
Review comment:
Import order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
