morningman commented on a change in pull request #4205:
URL: https://github.com/apache/incubator-doris/pull/4205#discussion_r462247082
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -2733,12 +2733,12 @@ public void dropDb(DropDbStmt stmt) throws DdlException
{
fullNameToDb.remove(db.getFullName());
final Cluster cluster = nameToCluster.get(db.getClusterName());
cluster.removeDb(dbName, db.getId());
- editLog.logDropDb(dbName, !stmt.isNeedCheckCommittedTxns());
+ editLog.logDropDb(dbName, stmt.isForceDrop());
Review comment:
I suggest to modify it like this:
```
DropDbInfo info = new DropDbInfo(dbName, stmt.isForceDrop());
editLog.logDropDb(info);
```
Just like other `editLog.logxxx()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
