yiguolei commented on code in PR #22170:
URL: https://github.com/apache/doris/pull/22170#discussion_r1273365937
##########
be/src/olap/utils.h:
##########
@@ -281,19 +281,7 @@ struct RowLocation {
uint32_t segment_id;
uint32_t row_id;
- bool operator==(const RowLocation& rhs) const {
- return rowset_id == rhs.rowset_id && segment_id == rhs.segment_id &&
row_id == rhs.row_id;
Review Comment:
do not modify this, because when other people refactor rowlocations, for
example, change the order of rowset_id and segment_id, the result of operator <
is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]