HappenLee commented on code in PR #22229:
URL: https://github.com/apache/doris/pull/22229#discussion_r1274560592
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -1840,14 +1839,16 @@ Status IRuntimeFilter::update_filter(const
UpdateRuntimeFilterParamsV2* param,
}
Status
RuntimePredicateWrapper::get_push_exprs(std::vector<vectorized::VExprSPtr>*
container,
- const
vectorized::VExprContextSPtr& prob_expr) {
- DCHECK(container != nullptr);
- DCHECK(_pool != nullptr);
- DCHECK(prob_expr->root()->type().type == _column_return_type ||
- (is_string_type(prob_expr->root()->type().type) &&
+ const TExpr& probe_expr) {
+ vectorized::VExprContextSPtr probe_ctx;
+ RETURN_IF_ERROR(vectorized::VExpr::create_expr_tree(probe_expr,
probe_ctx));
+ _probe_ctxs.push_back(probe_ctx);
Review Comment:
the op need lock else may be cause coredump
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
