yiguolei commented on code in PR #22315:
URL: https://github.com/apache/doris/pull/22315#discussion_r1276993159
##########
be/src/olap/delete_handler.cpp:
##########
@@ -61,9 +61,9 @@ Status DeleteHandler::generate_delete_predicate(const
TabletSchema& schema,
// Check whether the delete condition meets the requirements
for (const TCondition& condition : conditions) {
if (check_condition_valid(schema, condition) != Status::OK()) {
- LOG(WARNING) << "invalid condition. condition=" <<
ThriftDebugString(condition);
- return Status::Error<DELETE_INVALID_CONDITION>("invalid condition.
condition={}",
-
ThriftDebugString(condition));
+ // Error will print log, no need to do it manually.
+ return Status::Error<DELETE_INVALID_CONDITION>("invalid condition
on Column {}.",
+
condition.column_name);
Review Comment:
ThriftDebugString is right. It will output more info, not only column name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
